Skip to content
Failed

Changes

Summary

  1. Make fields final. Remove redundant modifier on final-class (details)
  2. Make fields final. Remove protected-modifier in final class (details)
  3. Remove protected-modifier in final class (details)
  4. Remove redundant throws clause (details)
  5. Type inference. Use autoboxing for int (details)
  6. Use factory method for creating FileInputStream (details)
  7. Replace string concatenation in loop with StringBuilder (details)
  8. Simplify assertions (details)
  9. Replace deprecated Mockito-class (details)
Commit a4e38057ae1b300b5ddd2f4a42f278b0b08f6b69 by anosh
Make fields final. Remove redundant modifier on final-class
The file was modifiedcore/src/main/java/com/threerings/getdown/util/ProgressAggregator.java (diff)
The file was modifiedcore/src/test/java/com/threerings/getdown/util/ConfigTest.java (diff)
The file was modifiedcore/src/test/java/com/threerings/getdown/util/FileUtilTest.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/ProxyPanel.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/data/Digest.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/util/FileUtil.java (diff)
The file was modifiedcore/src/test/java/com/threerings/getdown/data/ClassPathTest.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/AbortPanel.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/Getdown.java (diff)
The file was modifiedcore/src/test/java/com/threerings/getdown/data/PathBuilderTest.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/tools/JarDiffPatcher.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/Log.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/data/Application.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/data/Resource.java (diff)
The file was modifiedcore/src/test/java/com/threerings/getdown/cache/GarbageCollectorTest.java (diff)
The file was modifiedcore/src/test/java/com/threerings/getdown/data/EnvConfigTest.java (diff)
Commit 2b30d9dab0b0e4d8faffab96dda082f1c7bc7709 by anosh
Make fields final. Remove protected-modifier in final class
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/Getdown.java (diff)
The file was modifiedcore/src/test/java/com/threerings/getdown/cache/ResourceCacheTest.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/Log.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/GetdownApp.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/StatusPanel.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/util/LaunchUtil.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/ProxyPanel.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/util/MessageUtil.java (diff)
Commit 245f5386ceb783c8fd20fbc0acf269502fd047e1 by anosh
Remove protected-modifier in final class
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/ProxyUtil.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/StatusPanel.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/RotatingBackgrounds.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/util/StringUtil.java (diff)
Commit 258d85b934615e992be8e69ca011f684f6f433a2 by anosh
Remove redundant throws clause
The file was modifiedcore/src/main/java/com/threerings/getdown/util/VersionUtil.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/tools/JarDiff.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/GetdownApp.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/data/Application.java (diff)
The file was modifiedcore/src/test/java/com/threerings/getdown/data/ClassPathTest.java (diff)
Commit 03ed2f52d1d75ca6202fb37d9a00d5e6fde60324 by anosh
Type inference. Use autoboxing for int
The file was modifiedcore/src/test/java/com/threerings/getdown/data/ClassPathTest.java (diff)
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/ProxyUtil.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/data/PathBuilder.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/data/Application.java (diff)
Commit 508ef73d8584149f7ef450fb1bbbd80a2a7fcab3 by anosh
Use factory method for creating FileInputStream
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/ProxyUtil.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/util/LaunchUtil.java (diff)
The file was modifiedcore/src/main/java/com/threerings/getdown/util/VersionUtil.java (diff)
Commit 42dfbe47356300c21907930cf8e5ec4a8d721b5f by anosh
Replace string concatenation in loop with StringBuilder
The file was modifiedlauncher/src/main/java/com/threerings/getdown/launcher/StatusPanel.java (diff)
Commit eb8c7f67fb19c0d0076a87f4be5db8f3cec6a341 by anosh
Simplify assertions
The file was modifiedcore/src/test/java/com/threerings/getdown/util/ConfigTest.java (diff)
Commit 513c40c735667b166f96cff9c9d101fdfc21a101 by anosh
Replace deprecated Mockito-class
The file was modifiedcore/src/test/java/com/threerings/getdown/data/PathBuilderTest.java (diff)