Summary
- Fix checkstyle
- SearchFilter.java: Used Collection.contains(). LDAPURL.java: Simplified equals().
- Use Collection.contains() Used early exits Removed duplicated code
- CommonSchemaElements.java: Changed getNormalizedNames() to return a Set instead of Iterable. *.java: Consequence of the change to CommonSchemaElements.getNormalizedNames(). Used early exits. Extracted method SchemaElementPanel.getAliases().
- VerifyIndex.java: In mainVerifyIndex(): - use Collection.contains() - release the shared lock in a finally clause
- Remove duplicated code
- Fix build (Eclipse did not give me any errors :( )
- Use Collection.contains()
- Use Collection.contains()
- Code cleanup Entry.java: In applyModification(), extracted methods applyModificationToObjectclass() and applyModificationToNonObjectclass(). In hasUserAttribute() and hasOperationalAttribute(), extracted method hasAttribute() Used Attribute.isReal() to explicit code + merged if statements. Attribute.java: Added isReal() -> !isVirtual(). AbstractAttribute.java: Implemented isReal(). In equals() extracted method valuesEqual(). In hasAllOptions() and optionsEqual(), extracted method hasAllOptions0().
- OPENDJ-1666 Code cleanup * org.opends.server.protocols.http.HttpConnectionHandler ** Fix copyright section ** Make code more readable *** Reformat *** Inline some local variables * org.opends.server.protocols.http.HTTPClientConnection ** Fix copyright section ** Reformat * org.opends.server.protocols.http.CollectClientConnectionsFilter ** Fix copyright * org.opends.server.protocols.http.CollectClientConnectionsFilterTest ** Reformat
- AutoRefactor'ed Modification.java
Change Type | Path in Repository | Path in Workspace |
---|---|---|
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.java | opendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/LDAPURL.java | opendj-server-legacy/src/main/java/org/opends/server/types/LDAPURL.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/SearchFilter.java | opendj-server-legacy/src/main/java/org/opends/server/types/SearchFilter.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/admin/ads/ServerDescriptor.java | opendj-server-legacy/src/main/java/org/opends/admin/ads/ServerDescriptor.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyEntryTask.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyEntryTask.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/NewEntryTask.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/NewEntryTask.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/BrowseSchemaPanel.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/BrowseSchemaPanel.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/LDAPEntryPanel.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/LDAPEntryPanel.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/util/NumSubordinateHacker.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/util/NumSubordinateHacker.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/SchemaBackend.java | opendj-server-legacy/src/main/java/org/opends/server/backends/SchemaBackend.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskBackend.java | opendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskBackend.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/DeleteSchemaElementsTask.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/DeleteSchemaElementsTask.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyAttributeTask.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyAttributeTask.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyObjectClassTask.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyObjectClassTask.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/NewSchemaElementsTask.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/NewSchemaElementsTask.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/SchemaElementPanel.java | opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/SchemaElementPanel.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/CommonSchemaElements.java | opendj-server-legacy/src/main/java/org/opends/server/types/CommonSchemaElements.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.java | opendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/util/SelectableCertificateKeyManager.java | opendj-server-legacy/src/main/java/org/opends/server/util/SelectableCertificateKeyManager.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/BackendToolUtils.java | opendj-server-legacy/src/main/java/org/opends/server/tools/BackendToolUtils.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/BackendToolUtils.java | opendj-server-legacy/src/main/java/org/opends/server/tools/BackendToolUtils.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/RebuildIndex.java | opendj-server-legacy/src/main/java/org/opends/server/tools/RebuildIndex.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/EntryContainer.java | opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/EntryContainer.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/VLVIndex.java | opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/VLVIndex.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.java | opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/VLVIndex.java | opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/VLVIndex.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/Schema.java | opendj-server-legacy/src/main/java/org/opends/server/types/Schema.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/AbstractAttribute.java | opendj-server-legacy/src/main/java/org/opends/server/types/AbstractAttribute.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/Attribute.java | opendj-server-legacy/src/main/java/org/opends/server/types/Attribute.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/Entry.java | opendj-server-legacy/src/main/java/org/opends/server/types/Entry.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/CollectClientConnectionsFilter.java | opendj-server-legacy/src/main/java/org/opends/server/protocols/http/CollectClientConnectionsFilter.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.java | opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPConnectionHandler.java | opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPConnectionHandler.java |
The file was modified | /trunk/opendj/opendj-server-legacy/src/test/java/org/opends/server/protocols/http/CollectClientConnectionsFilterTest.java | opendj-server-legacy/src/test/java/org/opends/server/protocols/http/CollectClientConnectionsFilterTest.java |
Change Type | Path in Repository | Path in Workspace |
The file was modified | /trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/Modification.java | opendj-server-legacy/src/main/java/org/opends/server/types/Modification.java |