Skip to content
Success

Changes

Summary

  1. Fix checkstyle
  2. SearchFilter.java: Used Collection.contains(). LDAPURL.java: Simplified equals().
  3. Use Collection.contains() Used early exits Removed duplicated code
  4. CommonSchemaElements.java: Changed getNormalizedNames() to return a Set instead of Iterable. *.java: Consequence of the change to CommonSchemaElements.getNormalizedNames(). Used early exits. Extracted method SchemaElementPanel.getAliases().
  5. VerifyIndex.java: In mainVerifyIndex(): - use Collection.contains() - release the shared lock in a finally clause
  6. Remove duplicated code
  7. Fix build (Eclipse did not give me any errors :( )
  8. Use Collection.contains()
  9. Use Collection.contains()
  10. Code cleanup Entry.java: In applyModification(), extracted methods applyModificationToObjectclass() and applyModificationToNonObjectclass(). In hasUserAttribute() and hasOperationalAttribute(), extracted method hasAttribute() Used Attribute.isReal() to explicit code + merged if statements. Attribute.java: Added isReal() -> !isVirtual(). AbstractAttribute.java: Implemented isReal(). In equals() extracted method valuesEqual(). In hasAllOptions() and optionsEqual(), extracted method hasAllOptions0().
  11. OPENDJ-1666 Code cleanup * org.opends.server.protocols.http.HttpConnectionHandler ** Fix copyright section ** Make code more readable *** Reformat *** Inline some local variables * org.opends.server.protocols.http.HTTPClientConnection ** Fix copyright section ** Reformat * org.opends.server.protocols.http.CollectClientConnectionsFilter ** Fix copyright * org.opends.server.protocols.http.CollectClientConnectionsFilterTest ** Reformat
  12. AutoRefactor'ed Modification.java
Revision 12788 by fabiop:
Fix checkstyle
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.javaopendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.java
Revision 12787 by JnRouvignac:
SearchFilter.java:
Used Collection.contains().

LDAPURL.java:
Simplified equals().
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/LDAPURL.javaopendj-server-legacy/src/main/java/org/opends/server/types/LDAPURL.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/SearchFilter.javaopendj-server-legacy/src/main/java/org/opends/server/types/SearchFilter.java
Revision 12786 by JnRouvignac:
Use Collection.contains()
Used early exits
Removed duplicated code
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/admin/ads/ServerDescriptor.javaopendj-server-legacy/src/main/java/org/opends/admin/ads/ServerDescriptor.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyEntryTask.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyEntryTask.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/NewEntryTask.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/NewEntryTask.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/BrowseSchemaPanel.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/BrowseSchemaPanel.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/LDAPEntryPanel.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/LDAPEntryPanel.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/util/NumSubordinateHacker.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/util/NumSubordinateHacker.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/SchemaBackend.javaopendj-server-legacy/src/main/java/org/opends/server/backends/SchemaBackend.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskBackend.javaopendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskBackend.java
Revision 12785 by JnRouvignac:
CommonSchemaElements.java:
Changed getNormalizedNames() to return a Set instead of Iterable.

*.java:
Consequence of the change to CommonSchemaElements.getNormalizedNames().
Used early exits.
Extracted method SchemaElementPanel.getAliases().
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/DeleteSchemaElementsTask.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/DeleteSchemaElementsTask.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyAttributeTask.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyAttributeTask.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyObjectClassTask.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/ModifyObjectClassTask.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/NewSchemaElementsTask.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/NewSchemaElementsTask.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/SchemaElementPanel.javaopendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/SchemaElementPanel.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/CommonSchemaElements.javaopendj-server-legacy/src/main/java/org/opends/server/types/CommonSchemaElements.java
Revision 12784 by JnRouvignac:
VerifyIndex.java:
In mainVerifyIndex():
- use Collection.contains()
- release the shared lock in a finally clause
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.javaopendj-server-legacy/src/main/java/org/opends/server/tools/VerifyIndex.java
Revision 12783 by JnRouvignac:
Remove duplicated code
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/util/SelectableCertificateKeyManager.javaopendj-server-legacy/src/main/java/org/opends/server/util/SelectableCertificateKeyManager.java
Revision 12782 by JnRouvignac:
Fix build (Eclipse did not give me any errors :( )
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/BackendToolUtils.javaopendj-server-legacy/src/main/java/org/opends/server/tools/BackendToolUtils.java
Revision 12781 by JnRouvignac:
Use Collection.contains()
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/BackendToolUtils.javaopendj-server-legacy/src/main/java/org/opends/server/tools/BackendToolUtils.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/tools/RebuildIndex.javaopendj-server-legacy/src/main/java/org/opends/server/tools/RebuildIndex.java
Revision 12780 by JnRouvignac:
Use Collection.contains()
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/EntryContainer.javaopendj-server-legacy/src/main/java/org/opends/server/backends/jeb/EntryContainer.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/jeb/VLVIndex.javaopendj-server-legacy/src/main/java/org/opends/server/backends/jeb/VLVIndex.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.javaopendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/VLVIndex.javaopendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/VLVIndex.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/Schema.javaopendj-server-legacy/src/main/java/org/opends/server/types/Schema.java
Revision 12779 by JnRouvignac:
Code cleanup


Entry.java:
In applyModification(), extracted methods applyModificationToObjectclass() and applyModificationToNonObjectclass().
In hasUserAttribute() and hasOperationalAttribute(), extracted method hasAttribute()
Used Attribute.isReal() to explicit code + merged if statements.


Attribute.java:
Added isReal() -> !isVirtual().

AbstractAttribute.java:
Implemented isReal().
In equals() extracted method valuesEqual().
In hasAllOptions() and optionsEqual(), extracted method hasAllOptions0().
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/AbstractAttribute.javaopendj-server-legacy/src/main/java/org/opends/server/types/AbstractAttribute.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/Attribute.javaopendj-server-legacy/src/main/java/org/opends/server/types/Attribute.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/Entry.javaopendj-server-legacy/src/main/java/org/opends/server/types/Entry.java
Revision 12778 by gaetan:
OPENDJ-1666 Code cleanup

* org.opends.server.protocols.http.HttpConnectionHandler
** Fix copyright section
** Make code more readable
*** Reformat
*** Inline some local variables

* org.opends.server.protocols.http.HTTPClientConnection
** Fix copyright section
** Reformat

* org.opends.server.protocols.http.CollectClientConnectionsFilter
** Fix copyright

* org.opends.server.protocols.http.CollectClientConnectionsFilterTest
** Reformat
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/CollectClientConnectionsFilter.javaopendj-server-legacy/src/main/java/org/opends/server/protocols/http/CollectClientConnectionsFilter.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.javaopendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPClientConnection.java
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPConnectionHandler.javaopendj-server-legacy/src/main/java/org/opends/server/protocols/http/HTTPConnectionHandler.java
The file was modified/trunk/opendj/opendj-server-legacy/src/test/java/org/opends/server/protocols/http/CollectClientConnectionsFilterTest.javaopendj-server-legacy/src/test/java/org/opends/server/protocols/http/CollectClientConnectionsFilterTest.java
Revision 12777 by JnRouvignac:
AutoRefactor'ed Modification.java
Change TypePath in RepositoryPath in Workspace
The file was modified/trunk/opendj/opendj-server-legacy/src/main/java/org/opends/server/types/Modification.javaopendj-server-legacy/src/main/java/org/opends/server/types/Modification.java